Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to help to recognize "What's part changed" correctly #90

Open
6 of 7 tasks
Quramy opened this issue Nov 17, 2017 · 0 comments
Open
6 of 7 tasks

Ability to help to recognize "What's part changed" correctly #90

Quramy opened this issue Nov 17, 2017 · 0 comments
Assignees

Comments

@Quramy
Copy link
Member

Quramy commented Nov 17, 2017

Naive difference detection engines (e.g. pixel-matching) sometimes don't work well.

For instance, someone committed with message, "modify header component size". He or she changed only header component and never touched any other components. However the naive difference detector unfortunately misunderstands "the entire page changed!" because it can't recognize the simple Y-dimension translation.

Goal

  • provide alternative way to recognize difference

Not goal

  • replacement pixel-match: pixel-match is still great solution. It's simple and fast enough. The new way should be optional.

Algorithm

Using local features matching based region recognition. See https://github.com/reg-viz/improve_reg_diff

TODO

  • Implement difference detector
  • Invoke new engine from reg-cli/cli
  • Invoke new engine from reg-cli/report. (OnDemand detection)
  • Introduce CLI option to tell reg-cli "enable smart diff"
    • Oops, I missed to write this option to README
  • Hoist the above option to reg-suit/core option. User can set this using regconfig.json
  • Add new view components to review the new comparison result
@Quramy Quramy self-assigned this Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant