Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search input does not filter the results #373

Open
ghost opened this issue May 4, 2021 · 3 comments
Open

Search input does not filter the results #373

ghost opened this issue May 4, 2021 · 3 comments
Labels

Comments

@ghost
Copy link

ghost commented May 4, 2021

Describe the bug

Search input does not filter the results

Reproduced step

Steps to reproduce the behavior:

  1. npm i -g reg-cli
  2. reg-cli visreg/reference visreg/test rvisreg/diff -R ./visreg/report.html
  3. open report
  4. filter name with '05_'
  5. everything is still shown

Expected behavior

I'm expecting one or more images to disappear when filtering.

Actual behavior

Filtering shows all screenshots regardless of the name (might be related to this reg-viz/reg-cli-report-ui#28) ?

Screenshots


Peek 2021-05-04 15-46

@ghost ghost added the bug label May 4, 2021
@sam8helloworld
Copy link

Without -X option, reg-cli don't create worker script for reg-cli-report-ui.
However, in reg-cli-report-ui, filtering action is in worker script :(

I suggest reg-cli create worker script, regardless of whether use -X or not.

@bokuweb
Copy link
Member

bokuweb commented Oct 17, 2021

sorry for late.I'll do some investigation later.

@ghost
Copy link
Author

ghost commented Oct 18, 2021

Hi @sam8helloworld , what script is it supposed to create when using option -X? Is it just a javascript file or do I need nodejs to run the html report with search functionality? I tried generating the report with the -X option, but search is still not working for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants