Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Retrieve the test job's nodelist when using the squeue backend #3184

Merged
merged 2 commits into from May 13, 2024
Merged

[bugfix] Retrieve the test job's nodelist when using the squeue backend #3184

merged 2 commits into from May 13, 2024

Conversation

ekouts
Copy link
Contributor

@ekouts ekouts commented May 2, 2024

Fixes #3174.

@ekouts ekouts added this to the ReFrame 4.7 milestone May 2, 2024
@ekouts ekouts requested review from vkarak and teojgo May 2, 2024 07:36
@ekouts ekouts self-assigned this May 2, 2024
@codecov Codecov
Copy link

codecov bot commented May 2, 2024 •
edited

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.66%. Comparing base (16d52b7) to head (ff41341).
Report is 145 commits behind head on master.

Files Patch % Lines
reframe/core/schedulers/slurm.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3184      +/-   ##
==========================================
+ Coverage   86.63%   86.66%   +0.02%     
==========================================
  Files          61       61              
  Lines       12049    12140      +91     
==========================================
+ Hits        10439    10521      +82     
- Misses       1610     1619       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekouts ekouts changed the title Set nodelist in the perflogs in squeue backend [bugfix] Set nodelist in the perflogs in squeue backend May 2, 2024
@vkarak
Update ReFrame Dockerfile in Docker compose setup
ff41341 
So as to be able to test more easily branches from different forks
@vkarak vkarak changed the title [bugfix] Set nodelist in the perflogs in squeue backend [bugfix] Retrieve the test job's nodelist when using the squeue backend May 8, 2024
@vkarak vkarak merged commit 94d9086 into reframe-hpc:master May 13, 2024
24 of 25 checks passed
@vkarak vkarak linked an issue May 13, 2024 that may be closed by this pull request
squeue backend does not update the job's nodelist #3174
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarak vkarak vkarak approved these changes

@teojgo teojgo teojgo approved these changes

Assignees

@ekouts ekouts

Labels
bugfix prio: normal schedulers
Projects
ReFrame Backlog
Status: Done
Milestone
ReFrame 4.7
Development

Successfully merging this pull request may close these issues.

squeue backend does not update the job's nodelist
3 participants
@ekouts @vkarak @teojgo