feat: Implement ALPS extension #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Split most of changes for `CompressCertExtension` made to `crypto/tls` files out and moved them to `u_` files. - Edited some `crypto/tls` files to achieve better programmability for uTLS. - Minor styling fix.
- Made necessary modifications to existing types to support ALPS. - Ported `ApplicationSettingsExtension` implementation from `ulixee/utls` by @blakebyrnes with some adaptation. Co-Authored-By: Blake Byrnes <115056+blakebyrnes@users.noreply.github.com>
This was referenced Nov 11, 2022
- Introducing `utlsFakeCustomExtension` to enable implementation for custom extensions to be exchanged via ALPS. - currently it doesn't do anything. Co-Authored-By: Blake Byrnes <115056+blakebyrnes@users.noreply.github.com>
- Fixed magic number `17` in `StatusRequestV2Extension` with pre-defined enum `extensionStatusRequestV2`.
bogdanfinn
added a commit
to bogdanfinn/utls
that referenced
this pull request
Nov 11, 2022
3 tasks
3 tasks
ewust
reviewed
Nov 17, 2022
| @@ -47,3 +51,83 @@ func (m *compressedCertificateMsg) unmarshal(data []byte) bool { | |||
| } | |||
| return true | |||
| } | |||
|
|
|||
| type utlsEncryptedExtensionsMsgExtraFields struct { | |||
There was a problem hiding this comment.
Should we be exporting these fields? Is it something a using application might want to be able to view?
There was a problem hiding this comment.
I don't believe so. customExtension is just a fake place holder that isn't in any published draft/standard, while applicationSettings could be set in Config for client and read from PeerApplicationSettings in ConnectionState.
jmwample
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented support for
ApplicationSettingsExtension-- now the handshake message could be recognized!PR based on #141. Fixes #124 and #140.
Credits: Major implementation work is done by @blakebyrnes in
ulixee/utls.