Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons misaligned in mobile Editor which makes them non-clickable #7353

Open
sebastiaanspeck opened this issue May 11, 2024 · 3 comments
Open
Labels
bug disabled via hotfix A label to remind us to remove the feature from yolo help wanted Please! ♥︎ Particularly useful features that everyone would love!

Comments

@sebastiaanspeck
Copy link
Contributor

Description

Buttons that do not fit the line on mobile are placed on a newline in the Editor which makes them non-clickable
IMG_2351

How to replicate the issue + URL

https://github.com/refined-github/refined-github/issues/new?assignees=&labels=bug&projects=&template=1_bug_report.yml

Extension version

24.2.8

Browser(s) used

Safari iOS

@fregante
Copy link
Member

fregante commented May 11, 2024

I think this has been fixed in Chrome but we haven't released for Safari in a while. I'll try to work on Refined GitHub a bit this month and release a new version everywhere.

Can you verify whether it works correctly in Chrome?

@sebastiaanspeck
Copy link
Contributor Author

Unfortunately I cannot test on mobile using Chrome as iOS would not allow me to download Refined GitHub in Chrome. I tried a 3rd party browser (Orion), which let me install Refined GitHub, but over there the issue was not solved, but I experienced a buggy GitHub with Refined GitHub when using Orion. Since Orion is a 3rd party browser, I just ignore my testing. I believe you on your blue eyes that it will be fixed when a new Safari release is done

fregante added a commit to refined-github/yolo that referenced this issue Jun 3, 2024
@fregante fregante added help wanted disabled via hotfix A label to remind us to remove the feature from yolo Please! ♥︎ Particularly useful features that everyone would love! labels Jun 3, 2024
@fregante
Copy link
Member

fregante commented Jun 3, 2024

I fixed this bug on collapsible-content-button but the same fix didn't work on table-input. Maybe I left something out.

PR welcome because this is a useful feature, but I disabled it via hotfix for now because this bug is very visible and annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug disabled via hotfix A label to remind us to remove the feature from yolo help wanted Please! ♥︎ Particularly useful features that everyone would love!
Development

No branches or pull requests

2 participants