Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fit-textarea causing significant slow down when adding PR review comments #4266

Closed
gmaclennan opened this issue Apr 22, 2021 · 5 comments
Closed
Labels
bug safari Related to Safari only

Comments

@gmaclennan
Copy link

Browser: Safari 14.0.3
Example URL: https://github.com/digidem/mapeo-mobile/pull/566/files#

When reviewing a PR and adding a code comment with multiple lines, refined github causes a slowdown that results in a typing appearing on the screen a second or so after keys are pressed.

I ran the profiler on the page and identified that each keypress is calling the fitTextArea() function and takes ~5ms.

Turning off the fit-textarea feature resolves the problem and typing is not delayed any more.

@gmaclennan gmaclennan added the bug label Apr 22, 2021
@yakov116
Copy link
Member

Will be fixed in the next release

@fregante
Copy link
Member

Confirmed and hopefully it will be fixed in the next release. I don’t know when that’ll happen in Safari because releases aren’t automated there yet #3686

@fregante
Copy link
Member

For the time being, yes, disabling the feature is highly advised. I had to do the same for the past few months.

@fregante
Copy link
Member

fregante commented Jun 6, 2021

We had to re-enable it due to #4275 unfortunately

@fregante
Copy link
Member

Closing because of #4447

I'd basically need to rewrite or replace fit-textareas to enable the feature everywhere:

@fregante fregante closed this as not planned Won't fix, can't repro, duplicate, stale Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug safari Related to Safari only
Development

No branches or pull requests

3 participants