Enable bypass-checks on more commit statuses

[benwaffle]

Right now, clicking on "details" for a travis build goes to this page, which is mostly useless:

100% of the time, I just click on "The build" to get to travis, where I can see logs and restart a build.

The feature request is to add a "Build log" link here:

[fregante]

This already exists on the PR page, but I think nowhere else. The problem is that it requires fetching each and every Check page, so we can’t do that for every commit, everywhere

The feature is called bypass-checks

[benwaffle]

I've confirmed it's enabled in my console, but the feature isn't working

[yakov116]

URL?

[fregante]

It works for me on Firefox

URL: xojs/xo#497

No RG

Notice the the underlined "Details" link and the URL in the status bar

RG

[benwaffle]

That section works for me, but I'm clicking on the build status dot

[fregante]

Yeah, the feature only works on the PR Mergeability box.

I wonder if we can change the feature to work on any of those popups, by waiting for them to open and fetching just in time. This might be fast enough for some.

selector-observer should make this relatively easy. Separately, it'd be good to know whether the GraphQL API has this piece of information so that we could reduce the HTTP requests.

[yakov116]

GraphQL needs a next of 7 to get the status check and it would have to check each commit. I would just do mem around the request. My question is will it be fast enough to replace the link which is created on the fly.

[fregante]

Next of 7?

[yakov116]

Nest

[yakov116]

I see now my auto correct took over sorry.
GraphQL need to be a nest 7 deep in order to get the details url

[fregante]

GQL is a bit verbose but if it’s fast it’s worth it, especially if we enable this “on open”

However it’s a separate improvement, I’d rather see this feature working in more places, even if sometimes it’s not fast enough (nothing breaks if it’s not fast enough anyway)

[benwaffle]

thanks @yakov116 and @fregante - the feature works perfectly!