Replace prepare with prepublishOnly #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old `prepare` was running before a publish but also when we `npm install`. This is not so good and breaks builds for windows users (#121). A fix for this is to only run the code before an actual publish. This can be configured with the `prepublishOnly` script name. See: https://docs.npmjs.com/misc/scripts#deprecation-note Fixes: #121
|
Seems fine! |
|
thank you @RobinMalfait and @adamwathan fix problem. You frozen us back to life ❤️❤️🙈🙏🙏🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #121 - and this also prevents running the scripts upon
npm install.Thoughts? @adamwathan