Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing binary op implementations for OrderedFloat #145

Open
indietyp opened this issue Oct 22, 2023 · 2 comments
Open

Missing binary op implementations for OrderedFloat #145

indietyp opened this issue Oct 22, 2023 · 2 comments

Comments

@indietyp
Copy link

indietyp commented Oct 22, 2023

Unlike the standard library or NotNan. OrderedFloat does not implement impl<'a, T> Add<&'a OrderedFloat<T>> for &'a OrderedFloat<T>, the same goes for Div and others.

Would it be possible add these implementations?

Thank you so much for the great library!

@mbrubeck
Copy link
Collaborator

Unfortunately, adding these impls triggered some weird type inference error/bug:

#91

@indietyp
Copy link
Author

That's too bad! Thank you for the quick reply.

Although I wonder how the std is able to provide them 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants