Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OrderedFloat and NotNan should implement geo::HasKernel (behind feature) #121

Open
MultisampledNight opened this issue Mar 6, 2023 · 0 comments · May be fixed by #122
Open

OrderedFloat and NotNan should implement geo::HasKernel (behind feature) #121

MultisampledNight opened this issue Mar 6, 2023 · 0 comments · May be fixed by #122

Comments

@MultisampledNight
Copy link
Contributor

MultisampledNight commented Mar 6, 2023 •
edited

The geo crate uses this to determine what kernel method for use for this type. Since OrderedFloat and NotNan are basically only wrappers for f64 and f32 (and other floats), we can safely assume that's always RobustKernel. Or even make the implementation of it generic depending on whether or not the internal type implements HasKernel.

I need this like right now (not to be merged, just publicly accessible), so I'll go ahead and setup a PR.
@MultisampledNight MultisampledNight linked a pull request Mar 6, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add geo::HasKernel interop MultisampledNight/rust-ordered-float
1 participant
@MultisampledNight