Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Improve (and complete) new CLI check #4500

Closed
6 of 11 tasks
thedavidprice opened this issue Feb 16, 2022 · 1 comment
Closed
6 of 11 tasks

[CI] Improve (and complete) new CLI check #4500

thedavidprice opened this issue Feb 16, 2022 · 1 comment
Assignees

Comments

@thedavidprice
Copy link
Contributor

thedavidprice commented Feb 16, 2022

continues work from:

cc @dac09 @jtoar

What's the point:

  • make test-project use more efficient
  • use test-project for CI
  • use test-project as a fixture for unit tests
  • remove CLI checks from E2E CI Workflow
  • add missing CLI checks to CI
  • replace telemetry-benchmarks workflow with this one

CLI checks

  • Need to run yarn rw dev and yarn rw serve
  • How to handle rw setup command: tailwindcss, chakra-ui, auth, deploy, etc: they all fail even if using yarn dev <command> --cwd ... due to setup trying to install yarn workspace web add ... during the process
  • enable rw check: currently has a legitimate error (there's a createContact mutation, but not service)
  • enable rw type-check: throwing "gql missing" error, which is not reproducible locally.

Codemods for build:test-project

  • resolve yarn rw lint errors in built test-project
  • resolve missing createContact in Service
  • add prerender to NotFoundPage and HomePage

build:test-project option

  • --re-build-fixture: option to build new project at ./__fixtures__/test-project
    • typescript
    • latest published version of Redwood Packages
    • remove yarn.lock
    • probably need to build in /tmp outside directory and then copy back ('cause Yarn 1)
  • --copy-from-fixture: default=true, when running build:test-project use codebase at __fixtures/test-project to copy into target directory instead of creating codebase from scratch
  • determine a process about when to rebuild __fixtures__/test-project: breaking change, adding feature/code to test, new codemod, etc.?

publishing Redwood packages

  • should we rebuild __fixtures__/test-project each time we publish?
    • probably "no"
  • ==> or just update package versions (along with script "update-package-versions)?
    • add __fixtures__/test-project packages to "update-package-versions"
@thedavidprice
Copy link
Contributor Author

Calling this one good as of #4563

Moving next steps over to #4486

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Archived
Development

No branches or pull requests

3 participants