remove typeof undefined checks where not necessary 🐃🪒 #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3bd595b:
|
msutkowski
reviewed
Nov 14, 2021
Comment on lines
56
to
64
| export const useIsomorphicLayoutEffect = | ||
| typeof window !== 'undefined' && | ||
| typeof window.document !== 'undefined' && | ||
| typeof window.document.createElement !== 'undefined' | ||
| window.document && | ||
| window.document.createElement | ||
| ? useLayoutEffect | ||
| : useEffect |
There was a problem hiding this comment.
Can this be even shorter? It looks like there are many implementations that are just:
typeof document !== 'undefined' ? useLayoutEffect : useEffect
There was a problem hiding this comment.
Hmm. I would normally say "those other implementations are probably wrong", but Andarist normally knows what he's doing.
I'm going to say leave this alone - it's there, we know it works.
markerikson
force-pushed
the
pr/remove-typeof
branch
from
f1ed0e4
to
3bd595b
Compare
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a bit of yak shaving, but I noticed we are doing the
typeof x === 'undefined'check in quite some places where we would not need to. I changed it tox === undefined(orx == nullif there was anx === nullcheck going on in parallel anyways).I kept the behaviour for non-local variables like
window,navigator,processandAbortController.