Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Link to essentials tutorial from RTKQ quick start #2009

Merged
merged 2 commits into from May 22, 2022

Conversation

Shrugsy
Copy link
Collaborator

@Shrugsy Shrugsy commented Feb 8, 2022

As per title - this hopes to remove some occurrences where people are unaware of the essentials tutorial when learning RTK Query.

I'm open to hear opinions on whether it is obvious enough, and whether it should be in an 'info' box or something instead

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 8, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bbe9d41:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration

@netlify
Copy link

netlify bot commented Feb 8, 2022

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit bbe9d41
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/628a7de995b5eb00089cd198
😎 Deploy Preview https://deploy-preview-2009--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@markerikson
Copy link
Collaborator

Yeah, let's make a few tweaks here:

  • Go ahead and put this in an info box
  • Have the link text say the "Redux Essentials" tutorial

Let's also put this in the "RTKQ Overview" page. At a minimum we should link the Essentials tutorial in the "Further Information" section at the bottom. I also feel like we should highlight the tutorials in an info box somewhere on the page, but I'm actually not sure where in that page it should go. Maybe we should move "Further Information" up? We could rename it to "Learn RTK Query", and put it before the "Basic Usage" section. I'm not 100% sold on that, but I do want the link to the tutorials to not get buried at the bottom of the page.

Thoughts?

@markerikson markerikson merged commit 2f1964b into reduxjs:master May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants