Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note that this is no longer recommended or maintained? #183

Open
fredrivett opened this issue Jan 6, 2023 · 0 comments
Open

Add note that this is no longer recommended or maintained? #183

fredrivett opened this issue Jan 6, 2023 · 0 comments

Comments

@fredrivett
Copy link

It seems from the latest redux testing documentation that mocking the store is no longer recommended:

Prefer writing integration tests with everything working together. For a React app using Redux, render a with a real store instance wrapping the components being tested. Interactions with the page being tested should use real Redux logic, with API calls mocked out so app code doesn't have to change, and assert that the UI is updated appropriately.

Do not try to mock selector functions or the React-Redux hooks! Mocking imports from libraries is fragile, and doesn't give you confidence that your actual app code is working.

On top of that, this repo hasn't had any commits in over 2 years, and no issues have been raised in over 12 months, so it seems to me this project is no longer active.

This wasn't obvious to me, as many answers online still recommend this package and only reading through documentation myself did I realise this. I've since updated stack overflow questions to make this more obvious, but think it would also make sense to update the README to include a note that this project is effectively deprecated.

If the owners/maintainers agree, I'm happy to put in a PR for it as a starting point, or of course feel free to do so yourselves if you want to control the wording.

Thanks folks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant