Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect not working with detox envinronment #2127

Closed
1 task done
Daha62 opened this issue Feb 6, 2024 · 2 comments
Closed
1 task done

Connect not working with detox envinronment #2127

Daha62 opened this issue Feb 6, 2024 · 2 comments

Comments

@Daha62
Copy link

Daha62 commented Feb 6, 2024

What version of React, ReactDOM/React Native, Redux, and React Redux are you using?

  • React: 18.2.0
  • ReactDOM/React Native: 18.2.0 / 0.72.9
  • Redux: 5.0.1
  • React Redux: 9.1.0

What is the current behavior?

While running detox tests in release or debug mode (doesn't matter) react-redux connect function doesn't work. It returns state but it is an initial despite that all requests successfully passed.
But when we downgrade react-redux package to 8.1.3 all works perfectly.

What is the expected behavior?

Detox tests on react-redux version 9.1.0 will work as on 8.1.3

Which browser and OS are affected by this issue?

IOS 16.4

Did this work in previous versions of React Redux?

  • Yes
@markerikson
Copy link
Contributor

markerikson commented Feb 6, 2024

This seems exceptionally surprising, because there is no actual change in how React-Redux v9 works internally from v8. Both rely on React's own useSyncExternalStore hook.

In fact, there was literally no change in connect whatsoever for v9.

I actually don't know what "Detox" is without looking it up (other than presumably some kind of test runner), and I'm also not an RN user.

At a bare minimum I'd need a full Github repo that demonstrates this happening, with instructions on how to run the tests and reproduce the issue in order to investigate it.

Beyond that, though, I have a lot of other things on my plate, and a lone bug report of connect not working is not something I'm going to have time to look at. (Not an attempt to brush you off, I'm just being very realistic and up front about how I have to allocate my time right now.)

My only other question atm is: does useSelector work in this environment?

@markerikson
Copy link
Contributor

This seems like it was probably a duplicate of #2150 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants