New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark theme for React Redux website. #1603
Comments
This is dependent on migrating the React-Redux docs to use Docusaurus v2. The Redux and RTK sites have been migrated, but we haven't yet done the React-Redux site, largely because the versioning aspect makes it more complex. If someone would like to tackle doing the migration, that would be appreciated. |
Can I take this? I'll try to migrate it to v2. |
@Reflex-Gravity Sure, go for it! Please use the existing Redux and RTK docs sites as a baseline. |
Sure, thanks. |
I would like to work on this issue, but I have not worked with Docusaurus and am facing a few problems to get it up and running (was unable to trigger onClick event in react and was unable to figure out where to modify the header from). I was planning to add the dark mode using filter: invert(1) hue-rotate(180deg); Could you help me with these issues @markerikson ? |
@ruppysuppy : as I said above, the right answer here is to migrate our docs to Docusaurus v2. If you'd like to work on that I'd really appreciate it, but no, a CSS hack like that is not the approach we need. You can see our DSv2 setups for Redux Toolkit and the Redux core in their repos, like https://github.com/reduxjs/redux-toolkit/tree/master/website . The biggest issue with doing it for React-Redux is how the docs versioning gets handled. |
@markerikson, I would like to give it a try, but it might take a couple of days as I would have to go through Docusaurus docs |
@markerikson, I am unable to do it. The versioning does complicate it in Docusaurus 2. |
We upgraded to DSv2 in #1638 , so this is available now! |
Dark Theme for React Redux documents website.
I'd like to suggest implementing a Dark theme toggle switch for https://react-redux.js.org/ , the same way Redux website https://redux.js.org/ and Redux Toolkit website https://redux-toolkit.js.org/ have that small toggle switch at the right upper corner of the top navbar.
React Redux website navbar, with no theme toggle:
Redux website navbar, with a theme toggle:
Redux Toolkit navbar, with a theme toggle:
It really hurts your eyes when you read other Redux documents with dark theme and suddenly React Redux website is bright white.
The text was updated successfully, but these errors were encountered: