#1461 Add a displayName on ReactReduxContext #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-redux-docs ready! Built with commit 0762f49 |
|
That's not how the context works. |
@timdorr I don't understant why you say that. ReactDoc: https://reactjs.org/docs/context.html#contextdisplayname React-router do the same: https://github.com/ReactTraining/react-router/blob/master/packages/react-router/modules/RouterContext.js |
|
Crap, I was wrong. I thought you had to do that on each context pair component. |
|
Please either check the box that allows contributors to commit to this PR, or run this through our linting and testing toolchain. Right now it's failing because of the semicolon. |
|
O_O, sorry, I will fix that |
|
Thanks! Sorry about my confusion before. |
This was referenced Mar 8, 2020
This was referenced Mar 22, 2020
This was referenced Mar 30, 2020
This was referenced Apr 9, 2020
This was referenced Apr 28, 2020
webguru7
pushed a commit
to webguru7/react-redux
that referenced
this pull request
Dec 8, 2022
* reduxjs#1461 Add a displayName on ReactReduxContext * lint, remove semicolon reduxjs#1461
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve #1461