Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NOVALUES support to HSCAN #501

Closed
rueian opened this issue Mar 17, 2024 · 0 comments · Fixed by #503
Closed

Add NOVALUES support to HSCAN #501

rueian opened this issue Mar 17, 2024 · 0 comments · Fixed by #503
Labels
feature good first issue Good for newcomers help wanted Extra attention is needed

Comments

@rueian
Copy link
Collaborator

rueian commented Mar 17, 2024

Ref: redis/go-redis#2919

Suggested change:

Add a NOVALUES block to the end of:

"HSCAN": {
"summary": "Incrementally iterate hash fields and associated values",
"complexity": "O(1) for every call. O(N) for a complete iteration, including enough command calls for the cursor to return back to 0. N is the number of elements inside the collection..",
"arguments": [
{
"name": "key",
"type": "key"
},
{
"name": "cursor",
"type": "unsigned integer"
},
{
"command": "MATCH",
"name": "pattern",
"type": "pattern",
"optional": true
},
{
"command": "COUNT",
"name": "count",
"type": "integer",
"optional": true
}

and then run go generate


The NOVALUES block should look like:

      {
        "name": "NOVALUES",
        "type": "pure-token",
        "token": "NOVALUES",
        "optional": true
      }
@rueian rueian added help wanted Extra attention is needed good first issue Good for newcomers feature labels Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant