New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] The limit option of the xtrim command is invalid? #9046
Comments
I think it's a bug. I wil try to fix it. |
@monkey92t @huangzhw indeed a bug... thanks (discussion will continue in the PR) |
oranagra
pushed a commit
that referenced
this issue
Jun 7, 2021
The decision to stop trimming due to LIMIT in XADD and XTRIM was after the limit was reached. i.e. the code was deleting **at least** that count of records (from the LIMIT argument's perspective, not the MAXLEN), instead of **up to** that count of records. see #9046
Fixed in #9048 |
This was referenced Jun 30, 2021
Merged
Merged
oranagra
pushed a commit
to oranagra/redis
that referenced
this issue
Jul 20, 2021
…is#9048) The decision to stop trimming due to LIMIT in XADD and XTRIM was after the limit was reached. i.e. the code was deleting **at least** that count of records (from the LIMIT argument's perspective, not the MAXLEN), instead of **up to** that count of records. see redis#9046 (cherry picked from commit eaa7a7b)
oranagra
pushed a commit
that referenced
this issue
Jul 21, 2021
The decision to stop trimming due to LIMIT in XADD and XTRIM was after the limit was reached. i.e. the code was deleting **at least** that count of records (from the LIMIT argument's perspective, not the MAXLEN), instead of **up to** that count of records. see #9046 (cherry picked from commit eaa7a7b)
1 task
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this issue
Sep 8, 2021
…is#9048) The decision to stop trimming due to LIMIT in XADD and XTRIM was after the limit was reached. i.e. the code was deleting **at least** that count of records (from the LIMIT argument's perspective, not the MAXLEN), instead of **up to** that count of records. see redis#9046
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
limit 2
didn't work, all data was still removed ( return(integer) 3
), or is my understanding of thelimit
option wrong?The text was updated successfully, but these errors were encountered: