Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log the real reason for why posix_fadvise failed #13246

Merged
merged 1 commit into from May 21, 2024
Merged

Log the real reason for why posix_fadvise failed #13246

merged 1 commit into from May 21, 2024

Conversation

TedLyngmo
Copy link
Contributor

reclaimFilePageCache did not set errno but rdbSaveInternal which is logging the error assumed it did. This makes sure errno is set.

Fixes #13245

@TedLyngmo
Log the real reason for why posix_fadvise failed
fe7e602 
`reclaimFilePageCache` did not set `errno` but `rdbSaveInternal` which
is logging the error assumed it did. This makes sure `errno` is set.

Fixes redis#13245

Signed-off-by: Ted Lyngmo <ted@lyncon.se>
@TedLyngmo TedLyngmo mentioned this pull request May 4, 2024
Merged
@sundb sundb added the state:to-be-merged The PR should be merged soon, even if not yet ready, this is used so that it won't be forgotten label May 6, 2024
@sundb sundb merged commit e92363e into redis:unstable May 21, 2024
13 checks passed
@TedLyngmo TedLyngmo deleted the fix_13245 branch May 21, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundb sundb sundb approved these changes

@shahsb shahsb shahsb approved these changes

Assignees
No one assigned
Labels
state:to-be-merged The PR should be merged soon, even if not yet ready, this is used so that it won't be forgotten
Projects
Redis 7.2 Backport
Status: Todo
Redis 8.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Wrong error logged when reclaimFilePageCache fails
3 participants
@TedLyngmo @sundb @shahsb