Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-exception nonblocking I/O #948

Closed
nateberkopec opened this issue Sep 25, 2020 · 3 comments
Closed

Support non-exception nonblocking I/O #948

nateberkopec opened this issue Sep 25, 2020 · 3 comments

Comments

@nateberkopec
Copy link

Since Ruby 2.3, nonblocking I/O methods take exception: false, so they no longer have to raise exceptions when they would block.

def _read_from_socket(nbytes)

Not raising exceptions and immediately rescuing will increase performance.

Linking: petergoldstein/dalli#756

@byroot
Copy link
Collaborator

byroot commented Sep 25, 2020

Yeah I meant to use that since a while, I need to finish it: #926

@nateberkopec
Copy link
Author

Cheers! Just noticed it today in production, glad it's already on your radar.

@byroot
Copy link
Collaborator

byroot commented Sep 27, 2020

Done.

@byroot byroot closed this as completed Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants