Add transaction support for redis distributed #941
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to use
watch
andmulti
withRedis::Distributed
. My code looks like this:Given all keys can be tagged, they will all end up on the same node, so this should work with
Redis::Distributed
without issue. An additional assumption is that the caller will use the block syntax forwatch
which is thread safe, or will handle thread safety in another way outside ofRedis::Distributed
.I implemented that by keeping a copy of the key tag or the key if the key itself isn't tagged, and ensure that all commands are issued with the same key or key tag until one of these things happen:
exec
,unwatch
ordiscard
is explicitly calledexec
is implicitly called at the end of themulti
blockunwatch
is implicitly called when aStandardError
is raised within awatch
block