Use the exception: false API of read/write nonblock #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
read-nonblock-exception
branch
2 times, most recently
from
ea20ed9
to
6e21016
Compare
casperisfine
force-pushed
the
read-nonblock-exception
branch
from
6e21016
to
ff1ef3f
Compare
casperisfine
force-pushed
the
read-nonblock-exception
branch
from
ff1ef3f
to
c5b258d
Compare
casperisfine
changed the title
|
The connect_noblock is a bit trickier to handle, so I reduce the PR to just read and write. |
eregon
reviewed
Sep 27, 2020
| loop do | ||
| case bytes_written = write_nonblock(data, exception: false) | ||
| when :wait_readable | ||
| unless IO.select([self], nil, nil, @timeout) |
There was a problem hiding this comment.
Should this still use @write_timeout (and not @timeout)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be a nice optimization, just need to make sure it doesn't break anything (
Errno::EAGAIN,Errno::EWOULDBLOCKin connect is fishy).