Support KEEPTTL option in SET command #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, in the process of adding this small feature, I had to enable testing against redis 6. I'm not sure what the process for dealing with breaking behaviour changes, such as this test. If this is scope creep, or not something that you accept in a PR, I will remove it. |
|
Hi @ferrous26, can you split this in two PRs ? First test against Redis 6.0, then after that another PR to add the new feature. |
byroot
reviewed
Jun 5, 2020
byroot
reviewed
Jun 5, 2020
Merged
This option was introduced in Redis 6.0.0
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option was added in Redis 6.0.0. See https://redis.io/commands/set for documentation.