Fix TLS connections not verified by default #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SSLContext#set_params` is the step in SSL connection establishment that merges user-provided SSL parameters with "saner defaults". Previously `SSLContext#set_params` was only being called when `ssl_params` was provided to the SSLConnection, so the SSLContexet was left unconfigured. This leads to the surprising default `verify_mode` of `nil`, resulting in SSL connections verifying hostnames but never verifying certificate trust.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you specify an SSL URL for your client but do not specify some values in
ssl_params, you'll end up with a connection that does not actually verify the certificate. This is surprising: usually network clients using TLS would use VERIFY_PEER with a system certificate store. This probably went undetected because domain verification still happens by default - it's just the certificate chain that is skipped.SSLContext#set_paramsis the step in SSL connection establishment thatmerges user-provided SSL parameters with "saner defaults".
Previously
SSLContext#set_paramswas only being called whenssl_paramswas provided to the SSLConnection, so the SSLContexet wasleft unconfigured. This leads to the surprising default
verify_modeofnil, resulting in SSL connections verifying hostnames but neververifying certificate trust.