Extend SlotLoader to work with multiple slot ranges #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supercaracal
approved these changes
Mar 22, 2020
byroot
reviewed
Mar 22, 2020
|
Code looks sane to me. I'll merge once you add the test @supercaracal required. |
With multiple resharding, different slot ranges can be assigned to a node. Current logic only pre assigns the last slot range, causing errors & retries for unassigned slots. This commit makes it work with multiple slot ranges and assigning all slots.
|
@byroot done |
|
cc @cliu55 |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With multiple resharding, different slot ranges can be assigned to a
node.
e.g.
Current logic only preassigns the last slot range, causing errors & retries for unassigned slots.
This commit makes it work with multiple slot ranges and assigning all slots.
I tested this locally, but couldn't figure how to add tests for this scenario.
edit: Added partial tests.