Fix cluster connecting option bug #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byroot
approved these changes
Feb 1, 2020
lib/redis/cluster.rb
Outdated
| [Node.new(option.per_node_key, node_flags, option.use_replica?), | ||
| Slot.new(available_slots, node_flags, option.use_replica?)] | ||
| ensure | ||
| node.map(&:disconnect) | ||
| node&.map(&:disconnect) |
There was a problem hiding this comment.
Nitpick, but since the return values doesn't matter, .each would make sense here.
lib/redis/cluster/option.rb
Outdated
| def add_common_node_option_if_needed(options, node_opts, key) | ||
| return options if options[key].nil? && node_opts.first[key].nil? | ||
|
|
||
| options[key] = options[key] || node_opts.first[key] |
oh... Ruby 2.3 is EOL but I will accommodate |
|
Thanks! |
|
Thank you for your quick and polite reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #888.
I modified it as keeping node connecting option as Hash instead of URI.