README.md: Disable reconnecting which doubles the duration until unsubscribe #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Problem: In the "Timeouts" section in README, it says "If no message is
received after 5 seconds, the client will unsubscribe." but it actually
unsubscribes after 10 seconds. It's because by default reconnect_attempts is
1 and the client tries subscribing for 5 seconds twice.
* Solution: Explicitly set reconnect_attempts to 0
* This can be tricky for first time readers since the "Reconnections"
section comes after this "Timeouts" section.
* Alternative solution: change the description that it will unsubscribe
after 10 seconds.
byroot
force-pushed
the
master
branch
6 times, most recently
from
efe158b
to
dd4b6fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
received after 5 seconds, the client will unsubscribe." but it actually
unsubscribes after 10 seconds. It's because by default reconnect_attempts is
1 and the client tries subscribing for 5 seconds twice.
section comes after this "Timeouts" section.
after 10 seconds.