Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redis#queue is not thread safe #878

Closed
ioquatix opened this issue Oct 28, 2019 · 1 comment
Closed

Redis#queue is not thread safe #878

ioquatix opened this issue Oct 28, 2019 · 1 comment

Comments

@ioquatix
Copy link
Contributor

https://github.com/redis/redis-rb/blob/master/lib/redis.rb#L96-L123

Redis#queue is not thread safe because you cannot assume it's safe to read from a hash table when it's also being modified.

Additionally, the hash uses a default constructor which means Redis#queue may actually modify the hash table.

So there are a number of issues with the implementation.
ioquatix added a commit to ioquatix/redis-rb that referenced this issue Oct 28, 2019
@ioquatix
Avoid data corruption in #queue.
82d81b6 
Potential fix for redis#878.
@ioquatix ioquatix mentioned this issue Oct 28, 2019
Merged
@byroot
Copy link
Collaborator

byroot commented Oct 28, 2019

Thanks

@byroot byroot closed this as completed Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ioquatix @byroot