Fix cluster node selection for SCAN, SSCAN, HSCAN, ZSCAN #1063
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that while using
SSCAN
on a stable cluster (where no hash slots are being moved from one node to another) we were getting a lot ofMOVED
responses.Upon investigation we saw that for
SSCAN
the client was selecting a random writer node. I may be missing the original intent of the removed branch of thecase
statement but it seems like we shouldn't care about the position of thematch
option as the argument for it is a pattern not a key. Before this changeCluster#find_node_key
was returningnil
for all flavors of scan which was causingCluster#find_node
to select a random node. Tested out this branch and theMOVED
responses went away whileSSCAN
continued to function normally.