Deprecate calling commands on the original Redis instance in multi (block) #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
multi-deprecation
branch
5 times, most recently
from
48328ea
to
5684ffa
Compare
…lock)
The new favored API is:
```ruby
redis.multi do |transaction|
transaction.get("foo")
transaction.del("bar")
end
```
This API allow multiple threads to build transactions concurrently on the same
connection, and is more friendly to Fiber based concurrency.
Fix: redis#1057
casperisfine
force-pushed
the
multi-deprecation
branch
from
5684ffa
to
cbc3bdd
Compare
|
Would this deprecation also apply for calls to |
No. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup #1059 for
multi.The new favored API is:
This API allow multiple threads to build pipelines concurrently on the same
connection, and is more friendly to Fiber based concurrency.
Fix: #1057