Restore Redis 4.3.0 accidental AUTH fallback behavior with a deprecation warning #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
restore-auth-bug
branch
2 times, most recently
from
504eaad
to
e432303
Compare
casperisfine
force-pushed
the
restore-auth-bug
branch
from
e432303
to
362c8c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #1038
As discussed in the related issue. This behavior wasn't a feature at all, but apparently quite a few people have totally incorrect usernames in their connection string, and it somewhat worked until now. So let's be nice and try to give them a warning.
I'm really unsure how visible that warning will be, but it might help a few people migrate cleanly. When we'll remove that mis-feature, I'll make sure to raise a comprehensible error.