match appropriate error message in Client.connect rescue CommandError #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verajohne
changed the title
|
Can you please squash your commits? As for the rubocop failure, I'll change the config, that rule is silly. |
…connect rescue CommandError
verajohne
force-pushed
the
rescue_command_error_match_message
branch
from
ef27116
to
17ba094
Compare
|
@byroot I squashed the commits, could we merge this? |
|
Sure I'll merge on green. Sorry I didn't see your squash until now, I'm not notifed on push, that's just way too many notifications, I should have told you to ping me when you were done. |
Totally get that :) Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #990 all CommandErrors are being rescued here, including max connections resulting in
Redis::CommandError: ERR max number of clients reachedbeing rescued here and eventually rasied asRedis::ConnectionError: Connection lost (ECONNRESET).It is my understanding that #990 was a fix to #989 and specifically
Redis::CommandError: ERR wrong number of arguments for 'auth' command. We should instead match on this error message, and otherwise raise.