Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add missing Union type in method StreamCommands.xclaim() #2553

Merged
merged 1 commit into from
Jan 22, 2023
Merged

Fix: add missing Union type in method StreamCommands.xclaim() #2553

merged 1 commit into from
Jan 22, 2023

Conversation

ant1fact
Copy link
Contributor

Union was missing in front of [List[StreamIdT], Tuple[StreamIdT]] and VSCode was producing an error because of it. After adding Union the type annotation is correctly identified by VSCode.

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

`Union` was missing in front of `[List[StreamIdT], Tuple[StreamIdT]]` and VSCode was producing an error because of it.
After adding `Union` the type annotation is correctly identified by VSCode.
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2023

Codecov Report

Base: 92.27% // Head: 92.24% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (d1fa5fc) compared to base (8592cac).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2553      +/-   ##
==========================================
- Coverage   92.27%   92.24%   -0.04%     
==========================================
  Files         115      115              
  Lines       29613    29613              
==========================================
- Hits        27325    27316       -9     
- Misses       2288     2297       +9     
Impacted Files Coverage Δ
redis/commands/core.py 82.15% <ø> (ø)
redis/asyncio/cluster.py 91.68% <0.00%> (-0.33%) ⬇️
tests/test_cluster.py 96.73% <0.00%> (-0.22%) ⬇️
tests/test_asyncio/test_pubsub.py 99.37% <0.00%> (-0.16%) ⬇️
tests/test_asyncio/test_cluster.py 97.48% <0.00%> (-0.13%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Jan 18, 2023
@dvora-h dvora-h merged commit 5e258a1 into redis:master Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants