Add TIMEOUT to query class #2519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 92.24% // Head: 92.22% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2519 +/- ##
==========================================
- Coverage 92.24% 92.22% -0.02%
==========================================
Files 113 113
Lines 29357 29377 +20
==========================================
+ Hits 27079 27093 +14
- Misses 2278 2284 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dvora-h
reviewed
Dec 19, 2022
tests/test_asyncio/test_search.py
Outdated
|
|
||
|
|
||
| @pytest.mark.redismod | ||
| def test_timeout(): |
There was a problem hiding this comment.
@shacharPash Can you combine the 2 tests into one and rename it to test_query_timeout?
tests/test_asyncio/test_search.py
Outdated
| @pytest.mark.redismod | ||
| def test_not_number_timeout(modclient: redis.Redis): | ||
| q1 = Query("foo").timeout("not a number") | ||
| with pytest.raises(Exception): |
There was a problem hiding this comment.
Better to check for a more specific error
tests/test_search.py
Outdated
|
|
||
|
|
||
| @pytest.mark.redismod | ||
| def test_timeout(): |
There was a problem hiding this comment.
Same as the async tests...
dvora-h
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
$ toxpass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.