Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding connection step to bloom filter examples #2478

Merged
merged 2 commits into from Nov 30, 2022
Merged

Conversation

nermiller
Copy link
Contributor

Fixes #2415, adds a connect step to bloom commands

Copy link

@savynorem savynorem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nermiller sorry I didn't articulate this well - the connection will need to be after the import, then the connection name is what needs to be used - also, the return from create is a boolean, it can't actually be used to alter the data structure, so they'll need to be more like
import redis r = redis.Redis() r.bf().create("bloom", .01, 1000) r.bf().add("bloom", "foo")

The return values are pretty much only used as a success / fail / did something change type of measure, they don't return a way to access the object.

Apply feedback
@nermiller
Copy link
Contributor Author

@savynorem please review again. Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2022

Codecov Report

Base: 92.22% // Head: 92.19% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (5435cf9) compared to base (f492f85).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2478      +/-   ##
==========================================
- Coverage   92.22%   92.19%   -0.03%     
==========================================
  Files         113      113              
  Lines       29239    29239              
==========================================
- Hits        26965    26958       -7     
- Misses       2274     2281       +7     
Impacted Files Coverage Δ
tests/test_asyncio/test_search.py 98.26% <0.00%> (-0.35%) ⬇️
tests/test_cluster.py 96.86% <0.00%> (-0.23%) ⬇️
redis/asyncio/connection.py 86.44% <0.00%> (-0.13%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@savynorem savynorem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks great to me!

@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Nov 30, 2022
@chayim chayim changed the title [DOC BUG] Add r=redis.Redis() step to bloom commands Adding connection step to bloom filter examples Nov 30, 2022
@nermiller nermiller merged commit dfe2152 into master Nov 30, 2022
@nermiller nermiller deleted the redis-connect-docs branch November 30, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in documentation regarding initialisation of RedisBloom and TopK
4 participants