Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Deprecated LGTM #2473

Merged
merged 1 commit into from Dec 4, 2022
Merged

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Nov 27, 2022

The LGTM service is being shut off in two weeks. This pull request aims to remove all references to LGTM. Perhaps LGTM usage should be replaced with codeql, or a repository preferred tool, but IMHO that's the point of a different pull request.

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2022

Codecov Report

Base: 92.22% // Head: 92.20% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (7faa3e5) compared to base (c48dc83).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2473      +/-   ##
==========================================
- Coverage   92.22%   92.20%   -0.03%     
==========================================
  Files         113      113              
  Lines       29321    29321              
==========================================
- Hits        27042    27036       -6     
- Misses       2279     2285       +6     
Impacted Files Coverage Δ
tests/test_asyncio/test_search.py 98.26% <0.00%> (-0.35%) ⬇️
tests/test_search.py 98.94% <0.00%> (-0.22%) ⬇️
tests/test_cluster.py 96.89% <0.00%> (-0.12%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Nov 29, 2022
@chayim chayim changed the title Removing LGTM Removing Deprecated Dec 1, 2022
@chayim chayim changed the title Removing Deprecated Removing Deprecated LGTM Dec 1, 2022
@chayim chayim force-pushed the ck-removing-deprecated-lgtm branch from 2ec04d5 to 7faa3e5 Compare December 4, 2022 07:11
@chayim chayim requested a review from a team December 4, 2022 08:03
@chayim chayim merged commit f32c835 into redis:master Dec 4, 2022
@chayim chayim deleted the ck-removing-deprecated-lgtm branch December 4, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants