Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use explicit index name in RediSearch example #2466

Merged

Conversation

uglide
Copy link
Contributor

@uglide uglide commented Nov 20, 2022

Show how to set index name in the RediSearch example instead of using default value.

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

Show how to set index name in the RediSearch example instead of using default value.
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2022

Codecov Report

Base: 92.20% // Head: 92.21% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (cc9ae9f) compared to base (dfe2152).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2466   +/-   ##
=======================================
  Coverage   92.20%   92.21%           
=======================================
  Files         113      113           
  Lines       29239    29321   +82     
=======================================
+ Hits        26960    27037   +77     
- Misses       2279     2284    +5     
Impacted Files Coverage Δ
redis/cluster.py 90.34% <0.00%> (-0.36%) ⬇️
tests/test_cluster.py 96.78% <0.00%> (-0.09%) ⬇️
redis/asyncio/client.py 92.51% <0.00%> (ø)
tests/test_asyncio/test_lock.py 100.00% <0.00%> (ø)
redis/asyncio/cluster.py 91.78% <0.00%> (+0.10%) ⬆️
tests/test_asyncio/test_cluster.py 97.48% <0.00%> (+0.11%) ⬆️
redis/asyncio/connection.py 86.57% <0.00%> (+0.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Nov 21, 2022
@chayim chayim merged commit 37b961c into redis:master Dec 4, 2022
@uglide uglide deleted the doc_redisearch_show_index_name_in_example branch December 5, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants