Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install package deps in readthedocs build #2465

Merged
merged 2 commits into from Nov 21, 2022

Conversation

uglide
Copy link
Contributor

@uglide uglide commented Nov 20, 2022

Documentation doesn't contain autodoc sections for RediSearch and RedisJson modules:
image

The root cause is

WARNING: autodoc: failed to import module 'search.commands' from module 'redis.commands'; the following exception was raised:
No module named 'async_timeout'

from https://readthedocs.org/api/v2/build/18595317.txt

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

Dependencies are required for "automodule" generation.
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2022

Codecov Report

Base: 92.20% // Head: 92.20% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (75a2611) compared to base (e425674).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2465   +/-   ##
=======================================
  Coverage   92.20%   92.20%           
=======================================
  Files         113      113           
  Lines       29239    29239           
=======================================
+ Hits        26959    26961    +2     
+ Misses       2280     2278    -2     
Impacted Files Coverage Δ
tests/test_asyncio/test_search.py 98.26% <0.00%> (-0.35%) ⬇️
tests/test_cluster.py 96.97% <0.00%> (+0.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Nov 21, 2022
@dvora-h dvora-h merged commit f492f85 into redis:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants