Skip to content

Support TDIGEST.MERGESTORE and make compression optional on TDIGEST.CREATE #2319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 2, 2022

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Aug 2, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

closes #2309

Sorry, something went wrong.

@dvora-h dvora-h added the feature New feature label Aug 2, 2022
@dvora-h dvora-h requested a review from chayim August 2, 2022 13:24
dvora-h added 2 commits August 2, 2022 16:25

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2022

Codecov Report

Merging #2319 (cca1c95) into master (9901c79) will decrease coverage by 0.00%.
The diff coverage is 96.55%.

@@            Coverage Diff             @@
##           master    #2319      +/-   ##
==========================================
- Coverage   92.15%   92.15%   -0.01%     
==========================================
  Files         111      111              
  Lines       28659    28687      +28     
==========================================
+ Hits        26412    26437      +25     
- Misses       2247     2250       +3     
Impacted Files Coverage Δ
redis/commands/bf/commands.py 98.35% <85.71%> (-0.52%) ⬇️
tests/test_asyncio/test_bloom.py 99.57% <100.00%> (+0.02%) ⬆️
tests/test_bloom.py 99.59% <100.00%> (+0.01%) ⬆️
tests/conftest.py 84.94% <0.00%> (-0.78%) ⬇️
tests/test_cluster.py 96.85% <0.00%> (-0.12%) ⬇️
tests/test_asyncio/test_search.py 98.67% <0.00%> (+0.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@dvora-h dvora-h merged commit fcc0c41 into redis:master Aug 2, 2022
dvora-h added a commit that referenced this pull request Nov 21, 2022
…REATE (#2319)

* support 2.4

* async test

* skip tests

* linters
@dvora-h dvora-h deleted the bloom-2.4 branch June 18, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support TDIGEST.MERGESTORE and make compression optional on TDIGEST.CREATE
3 participants