-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add TDIGEST.TRIMMED_MEAN #2300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TDIGEST.TRIMMED_MEAN #2300
Conversation
@dvora-h I am having problem with running test on correct version of BloomFilter (test fails to find command of |
@bodevone You're right, the issue is in the docker, I'll trigger the CI again after it will fix |
@bodevone redismod docker fixed, now it should work. |
@bodevone You need to add this command to MODULE_CALLBACKS (in init.py) to convert the response to float. |
Codecov Report
@@ Coverage Diff @@
## master #2300 +/- ##
==========================================
+ Coverage 92.16% 92.18% +0.02%
==========================================
Files 111 111
Lines 28702 28713 +11
==========================================
+ Hits 26454 26470 +16
+ Misses 2248 2243 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I hope it's okay that I ended up doing it myself because we wanted to include it in the next version |
@dvora-h I am sorry for late response and yes it's totally okay |
* Add tdigest trimmed mean command with test * Add skip version for test * add to module callbacks Co-authored-by: Alibi Shalgymbay <a.shalgymbay@mycar.kz> Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com> Co-authored-by: dvora-h <dvora.heller@redis.com>
Pull Request check-list
Please make sure to review and check all of these items:
$ tox
pass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Add TDIGEST.TRIMMED_MEAN command
Closes #2196