Add support for SEARCH commands in cluster #2042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2042 +/- ##
==========================================
+ Coverage 92.17% 92.19% +0.02%
==========================================
Files 100 100
Lines 20998 21027 +29
==========================================
+ Hits 19355 19386 +31
+ Misses 1643 1641 -2
Continue to review full report at Codecov.
|
chayim
reviewed
Mar 10, 2022
| @@ -318,6 +318,42 @@ class RedisCluster(RedisClusterCommands): | |||
| ), | |||
| ) | |||
|
|
|||
| SEARCH_COMMANDS = ( | |||
There was a problem hiding this comment.
When we refactor, the way commands like this work are on the table for change.
chayim
reviewed
Mar 10, 2022
| @@ -183,7 +183,7 @@ def wait_for_cluster_creation(redis_url, cluster_nodes, timeout=60): | |||
| while now < end_time: | |||
| try: | |||
| client = redis.RedisCluster.from_url(redis_url) | |||
| if len(client.get_nodes()) == cluster_nodes: | |||
| if len(client.get_nodes()) == int(cluster_nodes): | |||
| print("All nodes are available!") | |||
There was a problem hiding this comment.
Can we remove this print statement? In general, even in tests, we shouldn't have prints.
chayim
reviewed
Mar 10, 2022
| @@ -52,13 +48,12 @@ def waitForIndex(env, idx, timeout=None): | |||
| break | |||
|
|
|||
|
|
|||
| def getClient(): | |||
| def getClient(client): | |||
chayim
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
$ toxpass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.