Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing AttributeError on some connection errors #1905

Merged
merged 2 commits into from Jan 26, 2022

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Jan 26, 2022

No description provided.

@chayim chayim added the bug Bug label Jan 26, 2022
@chayim chayim requested a review from dvora-h January 26, 2022 12:05
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2022

Codecov Report

Merging #1905 (13fcec4) into master (fb53a89) will increase coverage by 0.02%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1905      +/-   ##
==========================================
+ Coverage   92.95%   92.98%   +0.02%     
==========================================
  Files          76       76              
  Lines       16433    16437       +4     
==========================================
+ Hits        15276    15284       +8     
+ Misses       1157     1153       -4     
Impacted Files Coverage Δ
redis/connection.py 86.45% <40.00%> (-0.18%) ⬇️
tests/test_cluster.py 98.41% <0.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb53a89...13fcec4. Read the comment docs.

@chayim chayim merged commit 26491dc into redis:master Jan 26, 2022
@chayim chayim deleted the ck-conerror branch January 26, 2022 14:50
dvora-h pushed a commit to dvora-h/redis-py that referenced this pull request Feb 2, 2022
dvora-h added a commit that referenced this pull request Feb 2, 2022
* add redis5 and redis4 dockers

* redis versions testenv

* path changes

* fix linters

* fix tests

* fixing linter

* Increased pubsub's wait_for_messages timeout to prevent flaky tests (#1893)

* Fixing TypeError in GraphCommands.explain (#1901)

* Fixing AttributeError in UnixDomainSocketConnection (#1903)

* Fixing AttributeError on some connection errors (#1905)

* cluster script fixes to support future cluster versions and redis unstable (#1900)

* Fixing LMOVE, BLMOVE returning an incorrect response (#1906)

* Raising ConnectionError on invalid ocsp certificates - with status information (#1907)

* 4.1.2 (#1904)

* adding cluster env timeout time (#1908)

* Update changes file with changes since 4.0.0-beta2 (#1915)

* Fixing volume for unstable_cluster docker (#1914)

* Change json.clear test multi to be up to date with redisjson (#1922)

* fix json clear test

* fix json clear test

* Add support for BZMPOP (#1851)

* add bzmpop

* add comment

* fix pr comment

* fix linters

* fix pr comments

* add client no-evict (#1856)

* Add support for ZINTERCARD (#1857)

* add zintercard

* fix pr comment

* linters

* Add support for EVAL_RO (#1862)

* add sort_ro

* mark test as onlynon cluster

* delete mark test as onlynoncluster

* add eval_ro

* fix linters

* delete sort_ro

* fix pr comment

* add type hints

* add type hints

* linters

* Add support for EVALSHA_RO (#1863)

* add evalsha-ro

* fix pr comment

* add type hints

* add type hints

* Fix naming conventions (#1872)

* fix naming convention

* fix worng changes

* change ports to resolve conflict with unstable_cluster

Co-authored-by: Chayim I. Kirshen <c@kirshen.com>
Co-authored-by: Chayim <chayim@users.noreply.github.com>
Co-authored-by: Bar Shaul <88437685+barshaul@users.noreply.github.com>
Co-authored-by: Varun Chopra <v@chopraaa.com>
gkorland pushed a commit that referenced this pull request Feb 8, 2022
* add redis5 and redis4 dockers

* redis versions testenv

* path changes

* fix linters

* fix tests

* fixing linter

* Increased pubsub's wait_for_messages timeout to prevent flaky tests (#1893)

* Fixing TypeError in GraphCommands.explain (#1901)

* Fixing AttributeError in UnixDomainSocketConnection (#1903)

* Fixing AttributeError on some connection errors (#1905)

* cluster script fixes to support future cluster versions and redis unstable (#1900)

* Fixing LMOVE, BLMOVE returning an incorrect response (#1906)

* Raising ConnectionError on invalid ocsp certificates - with status information (#1907)

* 4.1.2 (#1904)

* adding cluster env timeout time (#1908)

* Update changes file with changes since 4.0.0-beta2 (#1915)

* Fixing volume for unstable_cluster docker (#1914)

* Change json.clear test multi to be up to date with redisjson (#1922)

* fix json clear test

* fix json clear test

* Add support for BZMPOP (#1851)

* add bzmpop

* add comment

* fix pr comment

* fix linters

* fix pr comments

* add client no-evict (#1856)

* Add support for ZINTERCARD (#1857)

* add zintercard

* fix pr comment

* linters

* Add support for EVAL_RO (#1862)

* add sort_ro

* mark test as onlynon cluster

* delete mark test as onlynoncluster

* add eval_ro

* fix linters

* delete sort_ro

* fix pr comment

* add type hints

* add type hints

* linters

* Add support for EVALSHA_RO (#1863)

* add evalsha-ro

* fix pr comment

* add type hints

* add type hints

* Fix naming conventions (#1872)

* fix naming convention

* fix worng changes

* change ports to resolve conflict with unstable_cluster

Co-authored-by: Chayim I. Kirshen <c@kirshen.com>
Co-authored-by: Chayim <chayim@users.noreply.github.com>
Co-authored-by: Bar Shaul <88437685+barshaul@users.noreply.github.com>
Co-authored-by: Varun Chopra <v@chopraaa.com>
(cherry picked from commit 0d26117)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants