Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation fixes: JSON Example, SSL Connection Examples, RTD version #1887

Merged
merged 2 commits into from Jan 19, 2022

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Jan 19, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Jan 19, 2022
@chayim chayim changed the title fixing ssl, json example, and versions Documentation fixes: JSON Example, SSL Connection Examples, RTD version Jan 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2022

Codecov Report

Merging #1887 (74ea90a) into master (90295ea) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1887      +/-   ##
==========================================
+ Coverage   92.97%   92.98%   +0.01%     
==========================================
  Files          76       76              
  Lines       16389    16389              
==========================================
+ Hits        15237    15239       +2     
+ Misses       1152     1150       -2     
Impacted Files Coverage Δ
tests/test_cluster.py 98.28% <0.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c605690...74ea90a. Read the comment docs.

@chayim chayim merged commit 7d23974 into master Jan 19, 2022
@chayim chayim deleted the ck-docminors branch January 19, 2022 15:55
dvora-h pushed a commit to dvora-h/redis-py that referenced this pull request Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants