Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ping interval #2321

Merged
merged 4 commits into from
Nov 10, 2022
Merged

Ping interval #2321

merged 4 commits into from
Nov 10, 2022

Conversation

leibale
Copy link
Collaborator

@leibale leibale commented Nov 10, 2022

fix #1598 fix #2276

add support for pingInterval

@leibale leibale merged commit 3c2f7ab into redis:master Nov 10, 2022
@leibale leibale deleted the ping-interval branch November 10, 2022 09:01
@jbeangreen
Copy link

@leibale pingInterval solves the primary subscriber client connection timeout tested with HAProxy but when connecting to Redis using both a Publisher and Subscriber it will fail as you cannot send commands on the subscriber client.

  • [redis-subscriber] Error: Cannot send commands in PubSub mode

@leibale
Copy link
Collaborator Author

leibale commented Nov 21, 2022

@jbeangreen nice catch! wanna open an issue about this?

@jbeangreen
Copy link

@leibale Sadly I'm swamped releasing a new stack, just wanted to bring this to your attention in case anyone else hits this issue. We have an advanced setup so I ended up jumping to ioredis as it allows to bypass the loadbalancer and connect to redis sentinels directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Socket closed unexpectedly setPingConnectionInterval for node-redis
2 participants