Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example script showing use of Hyperloglog commands. #2285

Closed
simonprickett opened this issue Oct 5, 2022 · 10 comments
Closed

Add example script showing use of Hyperloglog commands. #2285

simonprickett opened this issue Oct 5, 2022 · 10 comments

Comments

@simonprickett
Copy link
Contributor

Add an example script that shows the use of the PFADD and PFCOUNT and optionally PFMERGE commands (see Redis Hyperloglog Commands.

Make sure to use a real world example of the need to approximately count something, for example cars passing by a traffic monitoring camera perhaps. Check out our Hyperloglog video for examples.

Name your file hyperloglog.js. Pay attention to the guidelines for adding an example to ensure that your contribution can be merged.

This is part of our participation in Hacktoberfest 2022. Learn how to complete this issue here: https://redis.io/community/hacktoberfest/

Need help or want to talk to us? Join us on Discord where we have a dedicated Hacktoberfest channel: https://discord.gg/ueQwKUh5Z3

If you're interested in taking this issue on, please mention @simonprickett and @SuzeShardlow in the comments and ask to be assigned.

@Mephalich
Copy link

Hi. I could work on this task.

@simonprickett
Copy link
Contributor Author

@Mephalich thanks - we're aiming for a wide range of new contributors for Hacktoberfest, if this is still available in a week please check back but we'd like to ensure everyone gets a go at a first issue before assigning subsequent issues to folks who have already successfully completed one.

@SuzeShardlow
Copy link
Contributor

This issue is still open and up for grabs :) please reply and tag me and @simonprickett if you'd like to work on it.

@ade1705
Copy link
Contributor

ade1705 commented Oct 6, 2022

Hi @simonprickett @SuzeShardlow I would like to work on this

@SuzeShardlow
Copy link
Contributor

Hi @ade1705, I've assigned this one to you, look forward to seeing your PR in a couple of days. Please check out our guidelines at the below link and have fun!

https://redis.io/community/hacktoberfest/

@SuzeShardlow
Copy link
Contributor

Hi @ade1705, how are you doing with this? :)

@ade1705
Copy link
Contributor

ade1705 commented Oct 10, 2022

@SuzeShardlow almost done. Apologies for the delay

@ade1705
Copy link
Contributor

ade1705 commented Oct 10, 2022

@SuzeShardlow I have created a PR for it. Please have a look here

ade1705 added a commit to ade1705/node-redis that referenced this issue Oct 10, 2022
@SuzeShardlow
Copy link
Contributor

Thanks @ade1705! We will take a look in our daytime 😀

ade1705 added a commit to ade1705/node-redis that referenced this issue Oct 11, 2022
ade1705 added a commit to ade1705/node-redis that referenced this issue Oct 11, 2022
SuzeShardlow pushed a commit that referenced this issue Oct 14, 2022
#2289)

* #2285-Add-example-scripts-hyperloglog - Added hyperloglog examples to address Issue #2285

* #2285-Add-example-scripts-hyperloglog - Added the results as comments

* #2285-Add-example-scripts-hyperloglog - Changes from review

* #2285-Add-example-scripts-hyperloglog - Changes from review
@SuzeShardlow
Copy link
Contributor

Closed by #2289. Thanks @ade1705!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants