Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example script showing how to connect to a Redis open source cluster. #2281

Closed
simonprickett opened this issue Oct 4, 2022 · 16 comments
Closed

Comments

@simonprickett
Copy link
Contributor

Add an example script that shows how to connect to a Redis open source cluster. Your example can be based on the "Basic Example" code here: https://github.com/redis/node-redis/blob/master/docs/clustering.md

Name your file connect-to-cluster.js. Pay attention to the guidelines for adding an example to ensure that your contribution can be merged.

This is part of our participation in Hacktoberfest 2022. Learn how to complete this issue here: https://redis.io/community/hacktoberfest/

Need help or want to talk to us? Join us on Discord where we have a dedicated Hacktoberfest channel: https://discord.gg/ueQwKUh5Z3

If you're interested in taking this issue on, please mention @simonprickett and @SuzeShardlow in the comments and ask to be assigned.

@con-mark
Copy link
Contributor

con-mark commented Oct 4, 2022

@simonprickett @SuzeShardlow I would be interested in doing this but might not get it done till the weekend not sure if you want to assign it elsewhere

@Shamik1836
Copy link

@simonprickett @SuzeShardlow I can work on this and get this issue resolved today only if you assign this to me

@SuzeShardlow
Copy link
Contributor

@simonprickett @SuzeShardlow I would be interested in doing this but might not get it done till the weekend not sure if you want to assign it elsewhere

@con-mark, thanks for your message. We will assign this elsewhere as you suggest, but please keep your eyes peeled because we will be adding more issues in the coming days and weeks.

You can view our latest open issues at https://redis.io/community/hacktoberfest 😀

@SuzeShardlow
Copy link
Contributor

Hi @Shamik1836 I've assigned this to you, looking forward to seeing your PR in the next couple of days. Have fun and please check out our guidelines:

https://redis.io/community/hacktoberfest/

@Shamik1836
Copy link

Hi, can you please help me in finding some information about open source cluster, since this is my first open source contribution, I don't know where to get information about this but I really want to contribute to this issue.

@simonprickett
Copy link
Contributor Author

Hi there - we have a couple resources that may help:

Please note that in the interests of wide community involvement we can only keep these issues assigned for a couple of days, and we'll recycle them to other contributors if no PR's received in that timeframe.

@SuzeShardlow
Copy link
Contributor

@Shamik1836 as we have not heard anything from you, we are going to unassign this and reopen it to the community.

@SuzeShardlow
Copy link
Contributor

This issue is available and up for grabs. Please tag me and @simonprickett if you would like to work on it.

@vajid2113
Copy link

Hello, I would like to work on this issue @SuzeShardlow @simonprickett

@SuzeShardlow
Copy link
Contributor

Hi @vajid2113, I have assigned this to you :) we look forward to receiving your PR in a couple of days. Please check out our guidelines and have fun!

https://redis.io/community/hacktoberfest

@SuzeShardlow
Copy link
Contributor

Hi @vajid2113, how are you doing with this? :)

@varadkarpe
Copy link
Contributor

varadkarpe commented Oct 16, 2022

Hi @SuzeShardlow
If there are no updates regarding this issue from others I would like to contribute to this, I can get it done within 2 calendar days.

@SuzeShardlow SuzeShardlow assigned varadkarpe and unassigned vajid2113 Oct 16, 2022
@SuzeShardlow
Copy link
Contributor

@varadkarpe I've assigned this to you, looking forward to seeing your PR in the next couple of days. Have fun and please check out our guidelines:

https://redis.io/community/hacktoberfest/

@varadkarpe
Copy link
Contributor

Hey @SuzeShardlow
I am trying to push my code but I am facing an error, it says :
Permission to redis/node-redis.git denied to varadkarpe. fatal: unable to access 'https://github.com/redis/node-redis.git/': The requested URL returned error: 403

Can you please help me out?

@SuzeShardlow
Copy link
Contributor

SuzeShardlow commented Oct 18, 2022

Hi @varadkarpe, you can't push to our repo (as you've discovered) - you will have to fork the repo and make your changes there. Then push to your fork and open a PR against our repo.

Have a look at these instructions:

https://docs.github.com/en/get-started/quickstart/fork-a-repo

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork

@varadkarpe
Copy link
Contributor

#2298
I have made the PR, kindly review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants