disconnect in basic example

[reviewher]

Description

The basic example just hangs. It was missing the disconnect.

---

Checklist

• Does npm test pass with this change (including linting)?
• Is the new or changed code fully tested?
• Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

[leibale]

I'm pretty sure that most of the node apps are REST APIs, and in that scenario you don't want to .disconnect()/.quit()

@simonprickett @guyroyse WDUT?

[reviewher]

It's a "basic example" and listed as the first example in the README. There are no instructions for how to run it.

"Obviously" you start a local server and copy-paste the example to a MJS file and run it with node. Try it. The process will just hang.

The documentation can include a note about when disconnect/quit are appropriate.

[leibale]

Maybe we should leave the example as is and add a note with a link to this section

[reviewher]

If it is the case that "most of the node apps are REST APIs", then the "basic example" should be a simple REST server using raw Node HTTP server or ExpressJS.

The idea of a "basic example" IMHO is something you can run. A person who is new to node-redis will see the snippet with an actual import statement etc. and just test it out, wondering why the process is stuck.

[simonprickett]

I like the idea of having it in there?