Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broad usage of unchecked exceptions #3690

Open
avivfisher opened this issue Jan 15, 2024 · 0 comments
Open

Broad usage of unchecked exceptions #3690

avivfisher opened this issue Jan 15, 2024 · 0 comments

Comments

@avivfisher
Copy link

All of Jedis exceptions are extended from RuntimeException.
While the majority of Jedis exceptions are by definition, checked exceptions.
This behaviour is misleading and leading to a developer bugs, not handling those exceptions (or maybe just not at the right time).
For example:
JedisConnectionException is a RuntimeException while a connection error is an expect scenario (not a good one tho 😅).
So as a developer who uses Jedis, when I execute a command I have to go into the implementation to know which errors I need to handle because my implementation may differ between different exceptions.

Is there a specific reason which justify this kind of implementation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant