From 7a602818fd161a5cb1b31fbf5826f416f9b02974 Mon Sep 17 00:00:00 2001
From: sazzad16 <sazzad.cse.sust@gmail.com>
Date: Mon, 28 Oct 2019 12:46:19 +0600
Subject: [PATCH] format, re-order BuilderFactory

---
 .../redis/clients/jedis/BuilderFactory.java   | 190 +++++++++---------
 1 file changed, 92 insertions(+), 98 deletions(-)

diff --git a/src/main/java/redis/clients/jedis/BuilderFactory.java b/src/main/java/redis/clients/jedis/BuilderFactory.java
index 6f5e1566b9..410f2bec0e 100644
--- a/src/main/java/redis/clients/jedis/BuilderFactory.java
+++ b/src/main/java/redis/clients/jedis/BuilderFactory.java
@@ -13,6 +13,7 @@
 import redis.clients.jedis.util.SafeEncoder;
 
 public final class BuilderFactory {
+
   public static final Builder<Double> DOUBLE = new Builder<Double>() {
     @Override
     public Double build(Object data) {
@@ -32,6 +33,7 @@ public String toString() {
       return "double";
     }
   };
+
   public static final Builder<Boolean> BOOLEAN = new Builder<Boolean>() {
     @Override
     public Boolean build(Object data) {
@@ -43,10 +45,11 @@ public String toString() {
       return "boolean";
     }
   };
+
   public static final Builder<byte[]> BYTE_ARRAY = new Builder<byte[]>() {
     @Override
     public byte[] build(Object data) {
-      return ((byte[]) data); // deleted == 1
+      return (byte[]) data;
     }
 
     @Override
@@ -65,8 +68,24 @@ public Long build(Object data) {
     public String toString() {
       return "long";
     }
+  };
 
+  public static final Builder<List<Long>> LONG_LIST = new Builder<List<Long>>() {
+    @Override
+    @SuppressWarnings("unchecked")
+    public List<Long> build(Object data) {
+      if (null == data) {
+        return null;
+      }
+      return (List<Long>) data;
+    }
+
+    @Override
+    public String toString() {
+      return "List<Long>";
+    }
   };
+
   public static final Builder<String> STRING = new Builder<String>() {
     @Override
     public String build(Object data) {
@@ -77,8 +96,8 @@ public String build(Object data) {
     public String toString() {
       return "string";
     }
-
   };
+
   public static final Builder<List<String>> STRING_LIST = new Builder<List<String>>() {
     @Override
     @SuppressWarnings("unchecked")
@@ -102,52 +121,34 @@ public List<String> build(Object data) {
     public String toString() {
       return "List<String>";
     }
-
   };
-  public static final Builder<Map<String, String>> STRING_MAP = new Builder<Map<String, String>>() {
-    @Override
-    @SuppressWarnings("unchecked")
-    public Map<String, String> build(Object data) {
-      final List<byte[]> flatHash = (List<byte[]>) data;
-      final Map<String, String> hash = new HashMap<>(flatHash.size()/2, 1);
-      final Iterator<byte[]> iterator = flatHash.iterator();
-      while (iterator.hasNext()) {
-        hash.put(SafeEncoder.encode(iterator.next()), SafeEncoder.encode(iterator.next()));
-      }
 
-      return hash;
-    }
-
-    @Override
-    public String toString() {
-      return "Map<String, String>";
-    }
-
-  };
-
-  public static final Builder<Map<String, String>> PUBSUB_NUMSUB_MAP = new Builder<Map<String, String>>() {
+  public static final Builder<Set<String>> STRING_SET = new Builder<Set<String>>() {
     @Override
     @SuppressWarnings("unchecked")
-    public Map<String, String> build(Object data) {
-      final List<Object> flatHash = (List<Object>) data;
-      final Map<String, String> hash = new HashMap<>(flatHash.size()/2, 1);
-      final Iterator<Object> iterator = flatHash.iterator();
-      while (iterator.hasNext()) {
-        hash.put(SafeEncoder.encode((byte[]) iterator.next()),
-          String.valueOf((Long) iterator.next()));
+    public Set<String> build(Object data) {
+      if (null == data) {
+        return null;
       }
-
-      return hash;
+      List<byte[]> l = (List<byte[]>) data;
+      final Set<String> result = new HashSet<String>(l.size(), 1);
+      for (final byte[] barray : l) {
+        if (barray == null) {
+          result.add(null);
+        } else {
+          result.add(SafeEncoder.encode(barray));
+        }
+      }
+      return result;
     }
 
     @Override
     public String toString() {
-      return "PUBSUB_NUMSUB_MAP<String, String>";
+      return "Set<String>";
     }
-
   };
 
-  public static final Builder<Set<String>> STRING_SET = new Builder<Set<String>>() {
+  public static final Builder<Set<String>> STRING_ZSET = new Builder<Set<String>>() {
     @Override
     @SuppressWarnings("unchecked")
     public Set<String> build(Object data) {
@@ -155,7 +156,7 @@ public Set<String> build(Object data) {
         return null;
       }
       List<byte[]> l = (List<byte[]>) data;
-      final Set<String> result = new HashSet<>(l.size(), 1);
+      final Set<String> result = new LinkedHashSet<String>(l.size(), 1);
       for (final byte[] barray : l) {
         if (barray == null) {
           result.add(null);
@@ -168,9 +169,28 @@ public Set<String> build(Object data) {
 
     @Override
     public String toString() {
-      return "Set<String>";
+      return "ZSet<String>";
+    }
+  };
+
+  public static final Builder<Map<String, String>> STRING_MAP = new Builder<Map<String, String>>() {
+    @Override
+    @SuppressWarnings("unchecked")
+    public Map<String, String> build(Object data) {
+      final List<byte[]> flatHash = (List<byte[]>) data;
+      final Map<String, String> hash = new HashMap<String, String>(flatHash.size()/2, 1);
+      final Iterator<byte[]> iterator = flatHash.iterator();
+      while (iterator.hasNext()) {
+        hash.put(SafeEncoder.encode(iterator.next()), SafeEncoder.encode(iterator.next()));
+      }
+
+      return hash;
     }
 
+    @Override
+    public String toString() {
+      return "Map<String, String>";
+    }
   };
 
   public static final Builder<List<byte[]>> BYTE_ARRAY_LIST = new Builder<List<byte[]>>() {
@@ -236,47 +256,23 @@ public String toString() {
 
   };
 
-  public static final Builder<Set<String>> STRING_ZSET = new Builder<Set<String>>() {
-    @Override
-    @SuppressWarnings("unchecked")
-    public Set<String> build(Object data) {
-      if (null == data) {
-        return null;
-      }
-      List<byte[]> l = (List<byte[]>) data;
-      final Set<String> result = new LinkedHashSet<>(l.size(), 1);
-      for (final byte[] barray : l) {
-        if (barray == null) {
-          result.add(null);
-        } else {
-          result.add(SafeEncoder.encode(barray));
-        }
-      }
-      return result;
-    }
-
-    @Override
-    public String toString() {
-      return "ZSet<String>";
-    }
-
-  };
-
   public static final Builder<Tuple> TUPLE = new Builder<Tuple>() {
     @Override
     @SuppressWarnings("unchecked")
     public Tuple build(Object data) {
-      if (null == data) return null;
+      if (null == data) { // *Never* null. Still it doesn't hurt to be safe for future.
+        return null;
+      }
       List<byte[]> l = (List<byte[]>) data;
-      if (l.isEmpty()) return null;
-      return new Tuple(l.get(0), DOUBLE.build(l.get(1)));
+      Iterator<byte[]> i = l.iterator();
+      if (i.hasNext()) return new Tuple(i.next(), DOUBLE.build(i.next()));
+      return null;
     }
 
     @Override
     public String toString() {
       return "Tuple";
     }
-
   };
 
   public static final Builder<Set<Tuple>> TUPLE_ZSET = new Builder<Set<Tuple>>() {
@@ -299,7 +295,27 @@ public Set<Tuple> build(Object data) {
     public String toString() {
       return "ZSet<Tuple>";
     }
+  };
 
+  public static final Builder<Map<String, String>> PUBSUB_NUMSUB_MAP = new Builder<Map<String, String>>() {
+    @Override
+    @SuppressWarnings("unchecked")
+    public Map<String, String> build(Object data) {
+      final List<Object> flatHash = (List<Object>) data;
+      final Map<String, String> hash = new HashMap<String, String>(flatHash.size()/2, 1);
+      final Iterator<Object> iterator = flatHash.iterator();
+      while (iterator.hasNext()) {
+        hash.put(SafeEncoder.encode((byte[]) iterator.next()),
+          String.valueOf((Long) iterator.next()));
+      }
+
+      return hash;
+    }
+
+    @Override
+    public String toString() {
+      return "PUBSUB_NUMSUB_MAP<String, String>";
+    }
   };
 
   public static final Builder<Object> EVAL_RESULT = new Builder<Object>() {
@@ -366,16 +382,8 @@ public List<GeoCoordinate> build(Object data) {
       if (null == data) {
         return null;
       }
-      return interpretGeoposResult((List<Object>) data);
-    }
-
-    @Override
-    public String toString() {
-      return "List<GeoCoordinate>";
-    }
-
-    private List<GeoCoordinate> interpretGeoposResult(List<Object> responses) {
-      List<GeoCoordinate> responseCoordinate = new ArrayList<>(responses.size());
+      List<Object> responses = (List<Object>) data;
+      List<GeoCoordinate> responseCoordinate = new ArrayList<GeoCoordinate>(responses.size());
       for (Object response : responses) {
         if (response == null) {
           responseCoordinate.add(null);
@@ -388,6 +396,11 @@ private List<GeoCoordinate> interpretGeoposResult(List<Object> responses) {
       }
       return responseCoordinate;
     }
+
+    @Override
+    public String toString() {
+      return "List<GeoCoordinate>";
+    }
   };
 
   public static final Builder<List<GeoRadiusResponse>> GEORADIUS_WITH_PARAMS_RESULT = new Builder<List<GeoRadiusResponse>>() {
@@ -441,7 +454,7 @@ public List<GeoRadiusResponse> build(Object data) {
 
     @Override
     public String toString() {
-      return "GeoRadiusWithParamsResult";
+      return "List<GeoRadiusResponse>";
     }
   };
 
@@ -474,23 +487,6 @@ public String toString() {
     }
   };
 
-  public static final Builder<List<Long>> LONG_LIST = new Builder<List<Long>>() {
-    @Override
-    @SuppressWarnings("unchecked")
-    public List<Long> build(Object data) {
-      if (null == data) {
-        return null;
-      }
-      return (List<Long>) data;
-    }
-
-    @Override
-    public String toString() {
-      return "List<Long>";
-    }
-
-  };
-
   public static final Builder<StreamEntryID> STREAM_ENTRY_ID = new Builder<StreamEntryID>() {
     @Override
     @SuppressWarnings("unchecked")
@@ -583,8 +579,6 @@ public String toString() {
     }
   };
 
-
-
   private BuilderFactory() {
     throw new InstantiationError( "Must not instantiate this class" );
   }